lightningd: fix reference to uninitialized channel_type during opening. - #7031
Merged
Merged
Conversation
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added
Type::Bug
Member
|
ACK c6c879a |
It can change the node_announcement size, so don't check that. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
``` 2024-02-02T10:30:38.6479143Z __________________ ERROR at teardown of test_multifunding_one __________________ ... 2024-02-02T10:30:38.6491895Z > raise ValueError(str(errors)) 2024-02-02T10:30:38.6492208Z E ValueError: 2024-02-02T10:30:38.6492465Z E Node errors: 2024-02-02T10:30:38.6492833Z E - lightningd-2: had bad gossip messages 2024-02-02T10:30:38.6493535Z E Global errors: ... 2024-02-02T10:30:38.7458545Z lightningd-2 2024-02-02T10:25:48.410Z DEBUG 0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518-gossipd: Ignoring future channel_announcment for 103x2x1 (current block 102) 2024-02-02T10:30:38.7460140Z lightningd-2 2024-02-02T10:25:48.411Z UNUSUAL lightningd: Bad gossip order: could not find channel 103x2x1 for peer's channel update ``` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure how this got through CI...